8000 Add missing ClearModifiedPoints3D by sarlinpe · Pull Request #2761 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing ClearModifiedPoints3D #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add missing ClearModifiedPoints3D #2761

merged 1 commit into from
Sep 6, 2024

Conversation

sarlinpe
Copy link
Member
@sarlinpe sarlinpe commented Sep 6, 2024

Fixes #2582. Should make no difference in the default IncrementalPipeline because IterativeGlobalRefinement comes right after IterativeLocalRefinement but it could save some compute in a custom pipeline.

@sarlinpe sarlinpe requested a review from ahojnnes September 6, 2024 09:36
@ahojnnes ahojnnes merged commit 3f75f71 into main Sep 6, 2024
16 checks passed
@ahojnnes ahojnnes deleted the sarlinpe/fix-clearmodifiedpoints3d branch September 6, 2024 11:42
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why not use ClearModifiedPoints3D in the end of IterativeGlobalRefinement?
2 participants
@sarlinpe @ahojnnes
0