8000 Fix missing camera ptr for Reconstruction.DeleteAllPoints2DAndPoints3D() by B1ueber2y · Pull Request #2779 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix missing camera ptr for Reconstruction.DeleteAllPoints2DAndPoints3D() #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

B1ueber2y
Copy link
Contributor

Addresses #2775. Missed from #2762

@ahojnnes
Copy link
Contributor

Is it possible to construct a test case that covers the issue? Thanks for the fix.

@B1ueber2y
Copy link
Contributor Author

Is it possible to construct a test case that covers the issue? Thanks for the fix.

Added some tests in the reconstruction class (we need to add some pipeline tests in the future). PTAL when time permits. The point_triangulator breaks in the current head so we should merge this PR ASAP : )

Copy link
Contributor
@ahojnnes ahojnnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, small suggestion. Otherwise, LGTM.

@ahojnnes ahojnnes enabled auto-merge (squash) September 11, 2024 20:44
@ahojnnes ahojnnes merged commit 64e9fb5 into colmap:main Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error:'camera_ptr_' Must be non NULL when do sparse reconstruct from known camera poses
2 participants
0