8000 Add back some ceres bindings to use pycolmap bundle adjustment without pyceres by B1ueber2y · Pull Request #2985 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add back some ceres bindings to use pycolmap bundle adjustment without pyceres #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 4, 2024
Merged

Add back some ceres bindings to use pycolmap bundle adjustment without pyceres #2985

merged 9 commits into from
Dec 4, 2024

Conversation

B1ueber2y
Copy link
Contributor

Relevant discussion here: #2978

No need for import ceres in custom_bundle_adjustment.py anymore (relevant discussion: #2896)

@B1ueber2y
Copy link
Contributor Author

One would still need pyceres if the customized pycolmap cost functions and manifolds are needed, but this is a demand that only makes sense when the user is using pyceres to set up the problem.

@B1ueber2y B1ueber2y merged commit 290ec62 into colmap:main Dec 4, 2024
16 checks passed
@B1ueber2y B1ueber2y deleted the features/ceres_solver_options branch December 4, 2024 14:50
ahojnnes added a commit that referenced this pull request Dec 6, 2024
@B1ueber2y @ahojnnes
Add back some ceres bindings to use pycolmap bundle adjustment withou…
623eaac 
…t pyceres (#2985)

Relevant discussion here: #2978

No need for ``import ceres`` in ``custom_bundle_adjustment.py`` anymore
(relevant discussion: #2896)

---------

Co-authored-by: Johannes Schönberger <jsch@demuc.de>
@BrewTestBot BrewTestBot mentioned this pull request Dec 6, 2024
Merged
@B1ueber2y B1ueber2y mentioned this pull request Dec 18, 2024
Merged
HernandoR pushed a commit to HernandoR/colmap that referenced this pull request Dec 30, 2024
@B1ueber2y @ahojnnes
Add back some ceres bindings to use pycolmap bundle adjustment withou…
5248aad 
…t pyceres (colmap#2985)

Relevant discussion here: colmap#2978

No need for ``import ceres`` in ``custom_bundle_adjustment.py`` anymore
(relevant discussion: colmap#2896)

---------

Co-authored-by: Johannes Schönberger <jsch@demuc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahojnnes ahojnnes ahojnnes approved these changes

@sarlinpe sarlinpe sarlinpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B1ueber2y @ahojnnes @sarlinpe
0