8000 Separate read and write SAS tokens for vcpkg binary cache by ahojnnes · Pull Request #3027 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Separate read and write SAS tokens for vcpkg binary cache #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

ahojnnes
Copy link
Contributor
@ahojnnes ahojnnes commented Dec 10, 2024

Currently, PR from forks cannot run our CI pipeline, because secrets are not accessible for PRs originating from forks. See e.g. #3024. This PR fixes the issue by letting PRs from forks read but not write to the cache.

@ahojnnes ahojnnes marked this pull request as ready for review December 10, 2024 18:23
@ahojnnes ahojnnes merged commit 9da742c into main Dec 10, 2024
16 checks passed
@ahojnnes ahojnnes deleted the user/jsch/vcpkg-read-binary-cache branch December 10, 2024 19:09
HernandoR pushed a commit to HernandoR/colmap that referenced this pull request Dec 30, 2024
Currently, PR from forks cannot run our CI pipeline, because secrets are
not accessible for PRs originating from forks. See e.g.
colmap#3024. This PR fixes the issue by
letting PRs from forks read but not write to the cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0