8000 Improvements for reconstruction normalization / bbox / centroid by ahojnnes · Pull Request #3047 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvements for reconstruction normalization / bbox / centroid #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 16, 2024
Merged

Improvements for reconstruction normalization / bbox / centroid #3047

merged 13 commits into from
Dec 16, 2024

Conversation

ahojnnes
Copy link
Contributor
@ahojnnes ahojnnes commented Dec 16, 2024 •
edited
Loading
  • Use nth_element instead of sort for faster ordering.
  • Normalize in double precision to better handle large coordinates (e.g., GPS).
  • Use Eigen's AlignedBox instead of pair of Vector3d for bbox.
  • Extract bbox and centroid computation into reusable geometry module function. Add some more tests.

ahojnnes
ahojnnes commented Dec 16, 2024
View reviewed changes
sarlinpe
sarlinpe reviewed Dec 16, 2024
View reviewed changes
@ahojnnes ahojnnes requested a review from sarlinpe December 16, 2024 12:57
sarlinpe
sarlinpe reviewed Dec 16, 2024
View reviewed changes
sarlinpe
sarlinpe approved these changes Dec 16, 2024
View reviewed changes
@ahojnnes ahojnnes enabled auto-merge (squash) December 16, 2024 15:22
@ahojnnes ahojnnes merged commit d7951aa into main Dec 16, 2024
16 checks passed
@ahojnnes ahojnnes deleted the user/jsch/refactor-reconstruction-normalization branch December 16, 2024 15:50
HernandoR pushed a commit to HernandoR/colmap that referenced this pull request Dec 30, 2024
@ahojnnes
Improvements for reconstruction normalization / bbox / centroid (colm…
b63188f 
…ap#3047)

* Use nth_element instead of sort for faster ordering.
* Normalize in double precision to better handle large coordinates
(e.g., GPS).
* Use Eigen's AlignedBox instead of pair of Vector3d for bbox.
* Extract bbox and centroid computation into reusable geometry module
function. Add some more tests.
@BrewTestBot BrewTestBot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlinpe sarlinpe sarlinpe approved these changes

@B1ueber2y B1ueber2y Awaiting requested review from B1ueber2y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahojnnes @sarlinpe
0