Templating the static methods in the algorithm class IncrementalMapperImpl #3042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made an update to change all the shared_ptr arguments to const reference in the algorithm class: 24f9776 |
|
Actually we should remove dependencies across classes rather than doing static_assert. Will first improve the logic in a separate PR and then proceed with templating. |
Submitted here: #3043 |
B1ueber2y
added a commit
that referenced
this pull request
Dec 15, 2024
As mentioned in #3042, there are some dependencies in the graph that we need to take care of to avoid inconsistency, notably: * ``ObservationManager`` and ``DatabaseCache`` shares a same ``CorrespondenceGraph`` object, so should not be listed as input together to a static method * ``ObservationManager`` has a reference to the ``Reconstruction`` object, so should not be listed as input together with a ``Reconstruction`` object to a static method This PR contains the updates as follows: * use const ref rather than smart pointers as input in the algorithm class * use ``NumCorrespondencesForImage`` from ``CorrespondenceGraph`` rather than ``ObservationManager`` to avoid dependent input * add getter for the ``Reconstruction`` object to the ``ObservationManager`` class to avoid dependent input.
HernandoR
pushed a commit
to HernandoR/colmap
that referenced
this pull request
Dec 30, 2024
As mentioned in colmap#3042, there are some dependencies in the graph that we need to take care of to avoid inconsistency, notably: * ``ObservationManager`` and ``DatabaseCache`` shares a same ``CorrespondenceGraph`` object, so should not be listed as input together to a static method * ``ObservationManager`` has a reference to the ``Reconstruction`` object, so should not be listed as input together with a ``Reconstruction`` object to a static method This PR contains the updates as follows: * use const ref rather than smart pointers as input in the algorithm class * use ``NumCorrespondencesForImage`` from ``CorrespondenceGraph`` rather than ``ObservationManager`` to avoid dependent input * add getter for the ``Reconstruction`` object to the ``ObservationManager`` class to avoid dependent input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way we achieve reusability without touching the IncrementalMapper class. I also added static_assert to ensure type safety between Reconstruction and ObservationManager, and DatabaseCache and ObservationManager.
If we are happy with it I will move forward to update some core logics in the IncrementalTriangulator and ObservationManager to templated methods in an algorithm class in the following PRs as well.