8000 Make honeycomb logging an event rather than a span by mpcusack-color · Pull Request #40 · color/clr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Make honeycomb logging an event rather than a span #40

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Make honeycomb logging an event rather than a span #40

merged 8000 4 commits into from
Oct 28, 2021

Conversation

mpcusack-color
Copy link
Contributor
@mpcusack-color mpcusack-color commented Oct 28, 2021 •
edited
Loading

Previous version had two sets of issues:

  • Use of signals for beeline cleanup stoped control-c and django hot reload from working.
  • Using beeline traces interfered with instrumentation in commands.
    To fix these we move all clr honeycomb logging to a single event sent via an atexit function.

This PR also moves the package version into its own file so we can report it to honeycomb. No great ways to do that in python 3.6 (see https://packaging.python.org/guides/single-sourcing-package-version/), but this seemed the cleanest.

@mpcusack-color
Copy link
Contributor Author
mpcusack-color commented Oct 28, 2021 •
edited
Loading

FYI @gary-tsang-color I reverted your changes just to clean up the (public) git log. This pr should also fix the signal issue.

@mpcusack-color mpcusack-color merged commit 11262ff into master Oct 28, 2021
@mpcusack-color mpcusack-color deleted the mpcusack-honeycombfix branch October 28, 2021 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grounded042 grounded042 grounded042 approved these changes

@gary-tsang-color gary-tsang-color Awaiting requested review from gary-tsang-color

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpcusack-color @grounded042
0