8000 fix: run `browserless` instance and integrate w/ `puppeteer` 🍎 by ramiAbdou · Pull Request #603 · colorstackorg/oyster · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: run browserless instance and integrate w/ puppeteer 🍎 #603

New issu 8000 e

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 6, 2024
Merged

fix: run browserless instance and integrate w/ puppeteer 🍎 #603

merged 5 commits into from
Nov 6, 2024

Conversation

ramiAbdou
Copy link
Member

Description ✏️

This PR fixes an issue that requires the machine to have all of the OS dependencies needed to run Chromium. Instead, we'll use a Browserless instance via Docker that runs Chromium and allows to connect to it instead of launch a new browser.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Nov 5, 2024
@ramiAbdou ramiAbdou changed the title fix: run instance of browserless and connect w/ puppeteer-core 🍎 fix: run browserless instance and integrate w/ puppeteer 🍎 Nov 5, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review November 6, 2024 00:05
@ramiAbdou ramiAbdou merged commit 6c5fe80 into main Nov 6, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/browser branch November 6, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ramiAbdou ramiAbdou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramiAbdou
0