Fix docker orphan warnings, hanging localai_default network and ollama containers, and optimize start time through dependencies. #35
+94
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a containers, and optimize start time through dependencies.
|
To help with testing. This is what the output looks like when running and this is the output with the suggested PR with all identified issues corrected: |
Add health checks for all services to docker-compose file.
|
@ytkaczyk So sorry that it took me so long to get to this PR! I really appreciate your work. Someone in the Dynamous community has been helping me some with this package and he created this PR which I merged recently: I think that covers a lot of the same things, but maybe you could take a look if you are willing and see if there is a more atomic PR you could make that covers something here that isn't in 51? |
|
Hi @coleam00 . Thank you for the feedback and for sharing the new PR. If there had been any concerns about my original PR like the additional health checks, I would have been more than happy to amend it. I think collaborating on improvements might have helped to ensure that all intended code was included and to maintain authorship continuity. I’d appreciate it if you could reference the original PR in the new one and in the commit message, for attribution purposes. It looks like at least one change didn’t make it into the merged PR—I’ll go ahead and submit a follow-up when I get a chance. Please don’t hesitate to reach out if there’s anything I can adjust in it or if you have any preferences for PR messages and so forth. Thanks again for your work on this project and for everything you share with the open source community. I’m excited to continue contributing as I’m able. |
KacperRucinski
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following items:
warning msg=Found orphan containersstart_services.pyscript with no container running and with containers already runningincludetop level element instead of using multiple-farguments in the docker compose commands.localai_defaultnetwork not releases andollamacontainers still running when runningdocker compose downcommand--profileto the docker down command in thestart_services.pyscript and in the documentation--profileprevents the issue for happening and not clean up needed.ollamacontainers not updated when runningdocker compose pullcommandSymptoms: no ollama container displayed in the list when running the pull command
Fixed by adding the --profile to the docker pull command in the documentation
@coleam00 , I had to include one of the health checks from my other PR #34 since I added a dependency from n8n on qdrand and a health check was needed for that. I don't think it should but hope it doesn't create a conflict when you merge the two PRs but something to look out for.