Remove double quotation from parameter #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niols
reviewed
May 10, 2023
| @@ -483,7 +483,7 @@ | |||
| "'}'", | |||
| [ | |||
| [ | |||
| "WordDoubleQuoted", | |||
There was a problem hiding this comment.
I don't think this one is correct because now we have a WordSingleQuoted inside another WordSingleQuoted. I think that, similarly to the other cases, we should just remove the layer of WordDoubleQuoted altogether. Not entirely sure though.
|
The tests suite in CI is currently unreadable. This should be fixed by #169 so maybe we should wait for that, rebase this on top of |
Yes, let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, an extra set of double quotes surrounds every parameter. This pull request fixes that.
Test plan: