Report memory consumption percentage #501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another PR in my current streak of "relativity" related PRs which lets collectd do a bit more work to avoid computation later on.
|
Well, it took me a few days to get there but see https://github.com/katzj/collectd/tree/percent-mem |
|
+1 on the "make it consistent between plugins" notion. Since the changed to the df plugin are included in 5.4, i.e. we can't change them now, we should stick with that naming of config options. I also prefer to have one percentage for each value, because neither "used = allocated" nor "used = allocated + cache" is telling the whole story. |
|
agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR in my current streak of "relativity" related PRs which
lets collectd do a bit more work to avoid computation later on.
I hope to get as many eyes as possible on this from people not running linux.