adding mosquitto_loop after mosquitto_publish, otherwise qos=1 messag… #2730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es would not be considered acknowledged by the broker
…osquitto_loop call
mrunge
approved these changes
Apr 23, 2020
|
Thank you for your patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: collectd-mod-mqtt: hangs after 20 (qos=1) messages are sent
adding mosquitto_loop after mosquitto_publish, otherwise qos=1 messages would not be considered acknowledged by the broker.
A proposed fix for #2727
I haven't tested yet with messages of QoS=2 but now collectd-mod-mqtt is able to push more than 20 messages (without the mosquitto_loop reading the socket after mosquitto_publish, libmosquitto was unaware that the messages were acknowledged by the broker).