8000 Use test_utils_proc_pids only when compiling the plugin that uses it by dago · Pull Request #3197 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use test_utils_proc_pids only when compiling the plugin that uses it #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

Use test_utils_proc_pids only when compiling the plugin that uses it #3197

merged 1 commit into from
Jul 2, 2019

Conversation

dago
Copy link
Contributor
@dago dago commented Jul 1, 2019

This is a possible fix for #3194.

ChangeLog: Build system: Use test_utils_proc_pids only when compiling the plugin that uses it

@rpv-tomsk
Copy link
Contributor

Great, many thanks for your work!

@rpv-tomsk
Copy link
Contributor

cc @mrunge

It again looks like CI check stucks. This wastes developers time, while this is the most valuable resource.

@mrunge
Copy link
Member
mrunge commented Jul 1, 2019

cirrus checks did not succeed
In file included from src/lvm.c:29:0:
/usr/include/lvm2app.h:22:2: error: #warning "liblvm2app is deprecated, use D-Bus API instead." [-Werror=cpp]
#warning "liblvm2app is deprecated, use D-Bus API instead."
^
cc1: all warnings being treated as errors

@rubenk has a fix for this #3107
No idea, why it breaks CI right now.

@rpv-tomsk
Copy link
Contributor

cirrus checks did not succeed
In file included from src/lvm.c:29:0:
/usr/include/lvm2app.h:22:2: error: #warning "liblvm2app is deprecated, use D-Bus API instead." [-Werror=cpp]
#warning "liblvm2app is deprecated, use D-Bus A 8000 PI instead."
^
cc1: all warnings being treated as errors

Where did you find this message?

When looking "Details" on stuck CI https://github.com/collectd/collectd/pull/3197/checks?check_run_id=159266409 page shows "In progress" message.

When clicking on "View more details on Cirrus CI" https://cirrus-ci.com/task/6530728160919552 I see green check mark.

Finally, if CI check failed, we should see "failed" message, not "In progress".

@rpv-tomsk
Copy link
Contributor

Now, the https://cirrus-ci.com/task/5123353277366272 shows message about 'Failed to upload some logs'.

But all CI checks are passed now.... )))

@rpv-tomsk rpv-tomsk merged commit 3591872 into collectd:master Jul 2, 2019
@rpv-tomsk
Copy link
Contributor

Thanks, Dagobert!

@mrunge
Copy link
Member
mrunge commented Jul 2, 2019

Cirrus CI was strange on this. The report showed both: waiting and done. And going through the logs itself, it also showed the above mentioned error. Very fishy, in my eyes.

That doesn't invalidate this PR, thank you Dagobert!

@rpv-tomsk
Copy link
Contributor

Now it failing:

libtool: link: /opt/csw/bin/gcc -Wall -Werror -g -O2 -o test_plugin_curl_json src/test_plugin_curl_json-curl_json_test.o src/utils/curl_stats/test_plugin_curl_json-curl_stats.o src/daemon/test_plugin_curl_json-configfile.o src/daemon/test_plugin_curl_json-types_list.o -m32 -xarch=sparc -mcpu=v9  -L/opt/csw/lib ./.libs/libavltree.a ./.libs/liboconfig.a -lfl ./.libs/libplugin_mock.a -lpthread -lkstat -ldevinfo -lcurl -lcares -lnghttp2 -lidn2 -lrtmp -lssh2 -lpsl -lssl -lcrypto -lintl -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lldap -llber -lbrotlidec -lz -lrt -lsocket -lnsl -lyajl -R/opt/csw/lib
gcc: error: language arch=sparc not recognized
gcc: error: language arch=sparc not recognized
gcc: error: language arch=sparc not recognized
gcc: error: language arch=sparc not recognized
gcc: error: language arch=sparc not recognized
gcc: error: language arch=sparc not recognized
gmake[2]: *** [Makefile:6087: test_plugin_curl_json] Error 1
gmake[2]: Leaving directory '/export/home/buildbot-unstable10s/slave/collectd-solaris10-sparc/build'
gmake[1]: *** [Makefile:8829: check-am] Error 2
gmake[1]: Leaving directory '/export/home/buildbot-unstable10s/slave/collectd-solaris10-sparc/build'
gmake: *** [Makefile:8832: check] Error 2
program finished with exit code 2

@dago
Copy link
Contributor Author
dago commented Jul 2, 2019

The -xarch=sparc is inherited from the Perl installation used by the plugin which was compiled with the Oracle Studio compiler. The correct solution would be to use the Oracle Studio compiler also for collectd which shows some other errors at the moment. I suggest to close the issue here and I will investigate further and open issues/PRs as needed. Thanks!

@dago dago deleted the pid_test branch July 2, 2019 08:58
@dago dago restored the pid_test branch July 2, 2019 11:57
@dago dago mentioned this pull request Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpv-tomsk rpv-tomsk rpv-tomsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dago @rpv-tomsk @mrunge
0