[collectd 6] write_prometheus: migration to v6.0 #3861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would fix the following issues:
PS. You might want to check my "write_prometheus" patch for fixes to "http_handler()": #3917 |
|
I still need to test this, it's not forgotten. |
|
I've run this (PR) plugin with v6 code - tested my multiple server entries addition on this and v5. OK by me. |
6 tasks
eero-t
reviewed
Dec 23, 2021
| continue; | ||
| } | ||
| metric_family_destroy(fam); | ||
| metric_family_free(prom_fam); |
There was a problem hiding this comment.
After freeing "prom_fam", you cannot loop & use "prom_fam" members any more => you should break out of the loop here.
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Dec 23, 2021
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Dec 23, 2021
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Dec 27, 2021
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Jan 4, 2022
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Jan 11, 2022
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
I've been running this over a week now [1], and it's been working fine for me too. @mrunge & @elfiesmelfie any chance of getting this in, and closing the related 4 issues? (@manuelluis did not respond to my review comment above, but I can add separate PR for that after this goes in.) [1] with my "gpu_sysman" plugin updated to v6 API. I'll submit PR for that soon, but I'd like this to go in first. |
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Jan 27, 2022
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
eero-t
added a commit
to eero-t/collectd
that referenced
this pull request
Jan 27, 2022
Changes by "manuelluis" from: collectd#3861 For testing it with "gpu_sysman" plugin label support. Besides moving "write_prometheus" plugin to v6 API, this commit removes the obsolete protobuf support, and adds label support (= fix to related 3 open collectd tickets).
mrunge
approved these changes
Feb 3, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: write_prometheus plugin: migration to v6.0
The protocol-buffer support is removed as it is not supported after prometehus 2.0.