8000 patch required to build oracle plugin, collectd-5.4.0 (#653) by komeda-shinji · Pull Request #662 · collectd/collectd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

patch required to build oracle plugin, collectd-5.4.0 (#653) #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2014
Merged

patch required to build oracle plugin, collectd-5.4.0 (#653) #662

merged 4 commits into from
Jul 30, 2014

Conversation

komeda-shinji
Copy link
Contributor

configure failed with Symbol 'OCIEnvCreate' not found.
$with_oracle_libs should be added in $LIBS, not in $LDFLAGS

config.log

configure:22597: checking for OCIEnvCreate
configure:22597: gcc -o conftest -g -O2  -I/app/oracle/product/11.2.0/xe/rdbms/public  -L/app/oracle/product/11.2.0/xe/lib -lclntsh conftest.c -ldl  >&5
/tmp/ccEel8Uy.o: In function `main':
/usr/local/src/collectd-5.4.0/conftest.c:214: undefined reference to `OCIEnvCreate'
collect2: error: ld returned 1 exit status
configure:22597: $? = 1

pyr
pyr reviewed Jul 29, 2014
View reviewed changes
configure.ac
@@ -2982,14 +2982,14 @@ fi
if test "x$with_oracle" = "xyes"
then
SAVE_CPPFLAGS="$CPPFLAGS"
SAVE_LDFLAGS="$LDFLAGS"
SAVE_LIBS="$LDFLAGS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @komeda-shinji shouldn't this be SAVE_LIBS="$LIBS" ?

@mfournier mfournier removed the Patch label Jul 29, 2014
@komeda-shinji
Copy link
Contributor Author

I'm sorry, I mistake in SAVE_LIBS.
SAVE_LIBS="$LIBS" is correct.

@pyr
Copy link
Member
pyr commented Jul 30, 2014

Thanks @komeda-shinji !

pyr added a commit that referenced this pull request Jul 30, 2014
@pyr
Merge pull request #662 from komeda-shinji/fix-config-oracle
6e430c3 
patch required to build oracle plugin, collectd-5.4.0 (#653)
@pyr pyr merged commit 6e430c3 into collectd:master Jul 30, 2014
@mfournier
Copy link

FYI, I also cherry-picked these 2 patches to the collectd-5.3 branch, as this problem also affects older releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build An issue with the build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komeda-shinji @pyr @mfournier
0