ipmi: use SIGIO instead of SIGUSR2 to avoid conflict with JVM #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java uses SIGUSR2 to suspend/resume threads. The OpenIPMI plugins also need a signal to resume its event loop when setting a timer. They can't both use the same signal. We ask OpenIPMI to use SIGIO instead. This should fix collectd#114.
|
Jeez, @vincentbernat, I imagine this miserable one-line change must have cost you quite a few hours of troubleshooting ! Hats off :-) Have you already been able to build & run this patch on a system using the ipmi plugin ? I'm wondering about any tricky side effect this might have. Note: whenever this gets merged, it can (also) go to the collectd-4.10 branch (oldest supported bugfix branch). |
|
nice find, thanks @vincentbernat 🐼 |
pyr
added a commit
that referenced
this pull request
Jan 26, 2015
ipmi: use SIGIO instead of SIGUSR2 to avoid conflict with JVM
|
@mfournier On our production systems, I am running the workaround I mention in #114 (telling the JVM to use something else) instead. I have also checked with gdb that with our configuration SIGIO is left to SIG_DFL (which is to terminate the program). I'll try to test the fix on real systems soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java uses SIGUSR2 to suspend/resume threads. The OpenIPMI plugins also
need a signal to resume its event loop when setting a timer. They can't
both use the same signal. We ask OpenIPMI to use SIGIO instead.
This should fix #114.