fix: replace regex with string operations #12

brkicdusan · 2024-10-21T14:18:17Z

Resolves #11

coltiebaby

LGTM for the most part. Just wanna avoid having a runtime error happen if we get by index here.

coltiebaby · 2024-10-21T18:08:11Z

src/client.rs

+
+    for arg in args {
+        if arg.starts_with("--remoting-auth-token") {
+            let val = arg.split("=").collect::<Vec<&str>>()[1];


mind getting rid of the index here?

let val = arg.split("=").collect::<Vec<&str>>().first(); let token = val.ok_or(Error::AppNotRunning);

Yeah I'll change it no problem, though if I understand how args work it should always split into exactly 2 parts so this should still be fine I think.

you're probably right. This is just the only thing that's bitten us at work lately so i try to avoid it as much as possible.

Now that I changed it, it looks cleaner without indexing, plus it avoids needing to make a vector. I'm kind of new to rust still so I overcomplicate stuff like this a lot.

coltiebaby · 2024-10-21T18:08:19Z

src/client.rs

+            token = Ok(val);
+        }
+        if arg.starts_with("--app-port") {
+            let val = arg.split("=").collect::<Vec<&str>>()[1];


coltiebaby · 2024-10-21T18:47:54Z

Cool thanks!

fix: replace regex with string operations

25335c6

coltiebaby requested changes Oct 21, 2024

View reviewed changes

fix: replace index with last

916b8ea

brkicdusan requested a review from coltiebaby October 21, 2024 18:47

coltiebaby merged commit 0d04fb8 into coltiebaby:main Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: replace regex with string operations #12

fix: replace regex with string operations #12

fix: replace regex with string operations #12

fix: replace regex with string operations #12

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment