8000 Server add property pingCountMax by GDdark · Pull Request #255 · colyseus/colyseus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Server add property pingCountMax #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Server add property pingCountMax #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { Protocol } from './Protocol';

export type ServerOptions = IServerOptions & {
pingTimeout?: number,
pingCountMax?: number,
verifyClient?: WebSocket.VerifyClientCallbackAsync
presence?: any,
driver?: any,
Expand Down
12 changes: 8 additions & 4 deletions src/transport/WebSocketTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class WebSocketTransport extends Transport {

protected pingInterval: NodeJS.Timer;
protected pingTimeout: number;
protected pingCountMax: number;

constructor(matchMaker: MatchMaker, options: ServerOptions = {}, engine: any) {
super(matchMaker);
Expand All @@ -30,14 +31,17 @@ export class WebSocketTransport extends Transport {
this.pingTimeout = (options.pingTimeout !== undefined)
? options.pingTimeout
: 1500;
this.pingCountMax = (options.pingCountMax !== undefined)
? options.pingCountMax
: 2;

this.wss = new engine(options);
this.wss.on('connection', this.onConnection);

this.server = options.server;

if (this.pingTimeout > 0) {
this.autoTerminateUnresponsiveClients(this.pingTimeout);
if (this.pingTimeout > 0 && this.pingCountMax > 0) {
this.autoTerminateUnresponsiveClients(this.pingTimeout, this.pingCountMax);
}
}

Expand All @@ -52,14 +56,14 @@ export class WebSocketTransport extends Transport {
this.server.close();
}

protected autoTerminateUnresponsiveClients(pingTimeout: number) {
protected autoTerminateUnresponsiveClients(pingTimeout: number, pingCountMax: number) {
// interval to detect broken connections
this.pingInterval = setInterval(() => {
this.wss.clients.forEach((client: Client) => {
//
// if client hasn't responded after the interval, terminate its connection.
//
if (client.pingCount >= 2) {
if (client.pingCount >= pingCountMax) {
return client.terminate();
}

Expand Down
0