8000 __dirname compatibility & .js extension fix by nmime · Pull Request #824 · colyseus/colyseus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

__dirname compatibility & .js extension fix #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

__dirname compatibility & .js extension fix #824

merged 1 commit into from
Feb 24, 2025

Conversation

nmime
Copy link
Contributor
@nmime nmime commented Feb 24, 2025

No description provided.

@endel endel merged commit 414e3df into colyseus:master Feb 24, 2025
endel added a commit that referenced this pull request Feb 24, 2025
@endel
refactor __dirname support on ESM. post-merge #824
0c93ece
endel added a commit that referenced this pull request Feb 24, 2025
@endel
bump @colyseus/auth version #824
0c9f881
@endel
Copy link
Member
endel commented Feb 24, 2025

Thank you so much @nmime, I've just simplified a bit the getDirname() method, assuming if __dirname is not available, to use dirname(fileURLToPath(import.meta.url)) directly

Published in @colyseus/auth version 0.16.4 🙌

@nmime
Copy link
Contributor Author
nmime commented Feb 25, 2025

@endel can you also publish @colyseus/core (becaue of extensions)?

endel added a commit that referenced this pull request Feb 25, 2025
@endel
add missing extension on RoomExceptions import. #824
d1a8b98
@endel
Copy link
Member
endel commented Feb 25, 2025

Hi @nmime, sure thing, just release version 0.16.5 of @colyseus/core. There was indeed still a missing extension on RoomExceptions: d1a8b98

Let me know if that works for you 🙏

@nmime
Copy link
Contributor Author
nmime commented Feb 25, 2025

Thank you, @endel! It’s a pleasure working with you, everything works perfectly! 🚀🙏

endel added a commit that referenced this pull request Feb 26, 2025
@endel
fix imports without .js extension. bump version. (#824)
ecd5d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmime @endel
0