expose Presence setMaxListeners #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endel
added a commit
that referenced
this pull request
Apr 7, 2025
|
Thank you so much @sylvainpolletvillard, just bumped versions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node EventEmitter used in Presence has a built-in maxListeners used to try to detect and prevent memory leaks. Its default value is 10 listeners, which is short when you have more than 10 rooms that need:
Problem is the emitter is not exposed by Presence, so there's no way to call this setMaxListeners method from colyseus.
This PR exposes this setMaxListeners method so that we can set the presence maxListeners without changing the default value for all EventEmitters.