Enable fatal warnings #4515
Merged
Enable fatal warnings #4515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Feb 8, 2025
| @@ -477,14 +477,21 @@ trait MillScalaModule extends ScalaModule with MillJavaModule with ScalafixModul | |||
| def semanticDbVersion = Deps.semanticDBscala.version | |||
|
|
|||
| def scaladocOptions = Seq("-Xsource:3") | |||
|
|
|||
| def scalacOptions = | |||
| super.scalacOptions() ++ Seq( | |||
| "-deprecation", | |||
| "-feature" | |||
| ) ++ ( | |||
| if (ZincWorkerUtil.isScala3(scalaVersion())) Seq( | |||
| // "-Werror", | |||
There was a problem hiding this comment.
This is the progressive spelling of "warnings as error".
som-snytt
reviewed
Feb 8, 2025
| "-Wconf:msg=An existential type that came from a Scala-2 classfile:silent", | ||
| "-Wconf:msg=impo 8000 rt scala.language.implicitConversions:silent", | ||
| "-Wconf:msg=IterableOnceExtensionMethods:silent", | ||
| "-Wconf:msg=is deprecated:silent", |
There was a problem hiding this comment.
-Wconf:cat=deprecation:s is one of a few portable "categories".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing warnings were dealt with by a mix of fixing and silencing. We can tweak the set of silenced warnings later as necessary, but this is a significant step in ensuring all warnings are dealt with one way or another, and should prevent them uselessly piling up in the console logs