Split out Result and ExecResult types, replace Either[String, T] with Result
#4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae6a90f to
e700b3a
Compare
ae0f728 to
fdf996f
Compare
5a1b8b7 to
597a0aa
Compare
lefou
reviewed
Feb 11, 2025
| val outerStack = new mill.api.Result.OuterStack(base.getStackTrace) | ||
| Left(mill.api.Result.Exception(e, outerStack).toString) | ||
| } | ||
| class Exception(val error: String) extends java.lang.Exception(error) |
There was a problem hiding this comment.
Some ScalaDoc would be nice. What's the purpose of and when to use this exception?
There was a problem hiding this comment.
This is meant to replace the Result.Failure extends Exception we wanted to get rid of. I'll add Scaladoc later, I expect this to evolve significantly
lefou
reviewed
May 19, 2025
Comment on lines
+16
to
+21
| // val (doneMsg, testResults) = res | ||
| // testResults | ||
| // .groupBy(_.fullyQualifiedName) | ||
| // .view | ||
| // .mapValues(_.map(e => e.selector -> e).toMap) | ||
| // .toMap |
There was a problem hiding this comment.
This and some other tests were commented out. We should revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4527
Resultshould hopefully provide a simple user-facing result type, replacing the extensive use ofEither[String, T]throughout the codebase.ExecResultmodels the internals of theexec/module and really shouldn't be used elsewhere.Exactly how rich to make the
Resulttype is uncertain; this PR'sEither[String, T]version is easy and simple, but it's arguable whether we wantEither[Err, T]to be able to hold non-string errors, orEither[List[String], T]to be able to aggregate multiple errors (which we currently discard and pick the first one most of the time). But such changes can happen in future PRs any time before 0.13.0 is releasedFor now I just got rid of
ExecResult.Failure#value: Option[T]. We weren't using it anywhere but in unit tests, and it wasn't really suitable to downstream use by users AFAICT. We probably need to come up with a different way to e.g. gather data from failing test results, but this one probably was a failed experiment