Rework millEmbeddedDeps stuff #4546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ci/mill-bootstrap.patch
|
Thanks Alex! |
alexarchambault
added a commit
to alexarchambault/mill
that referenced
this pull request
Feb 18, 2025
This fixes an issue with GenIdea stuff that's been around since com-lihaoyi#4499 (that uncommented suggested code from com-lihaoyi#4145 to address some deprecations). IIUC, in `RootModule#bindDependency`, Mill excludes all of its dependencies, so that these are not pulled by plugins. The PR here excludes not only Mill dependencies, but also the Mill modules themselves (anything that the `dist.dist0` module depends on, itself included). Also, GenIdea tries to pull the class path of Mill itself, to pass it to IntelliJ. This class path is now pulled via `com.lihaoyi:mill-dist-dist0`, that should pull the whole class path of Mill. Fixes com-lihaoyi#4532 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Conflicts: ci/mill-bootstrap.patch main/package.mill runner/src/mill/runner/MillBuildRootModule.scala scalalib/src/mill/scalalib/Lib.scala
lihaoyi
pushed a commit
that referenced
this pull request
Feb 19, 2025
This reports #4546 on the `0.12.x` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with GenIdea stuff that's been around since #4499 (that uncommented suggested code from #4145 to address some deprecations).
IIUC, in
RootModule#bindDependency, Mill excludes all of its dependencies, so that these are not pulled by plugins. The PR here excludes not only Mill dependencies, but also the Mill modules themselves (anything that thedist.dist0module depends on, itself included).Also, GenIdea tries to pull the class path of Mill itself, to pass it to IntelliJ. This class path is now pulled via
com.lihaoyi:mill-dist-dist0, that should pull the whole class path of Mill.Fixes #4532