Make --no-server mode also terminate on removal of processId file, use it in integration test cleanup
#4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix some of the residual flakiness encountered in #4570
Somehow the recursive process termination we pulled in from upstream com-lihaoyi/os-lib#359 only works some of the time, and other times the processes get leaked. This PR extends the
serverId-file-deleted shutdown logic we already used for client-server mode and enables it for--no-servermode as well. This lets us put an additional guardrail in ourIntegrationTester#closeto delete any such files, to try and force any Mill processes to terminate.Added an additional integration test to exercise this behavior
Also fixed a bug in
ExampleTesternot honoring theclientServerModeflag, and updatetestkit.testto assert on those behaviors