Backport "Fix main class discovery for KotlinModule"
#4803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Mar 28, 2025
|
We don't need to, the alternative would be to copy-paste the |
|
We could, as you already suggested, just always use the classpath-based main class finder. I think it doesn't add much to the runtime. |
|
Yeah I think that's probably the next step. But this is the just backport of the previous PR, so didn't want to get too creative here |
|
I wanted to avoid the introduction of deprecated API. But if we do the next step before the release, it's fine too. |
d5facc7 to
837a078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4797
Fixes #4772
Previously it inherited the Zinc-based main class discovery via JavaModule, which overrode the generic classpath-scanning approach from RunModule. This PR adjusts the overrides such the KotlinModule uses the disk-based discovery API.
Removed all the now-unnecessary def mainClass annotations in the kotlinlib example tests, except for the one in example/kotlinlib/module/1-common-config that is useful for educational purposes.