8000 Consolidate define/api/runner-api into just define/api by lihaoyi · Pull Request #4899 · com-lihaoyi/mill · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Consolidate define/api/runner-api into just define/api #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 10, 2025
Merged

Consolidate define/api/runner-api into just define/api #4899

merged 13 commits into from
Apr 10, 2025

Conversation

lihaoyi
Copy link
Member
@lihaoyi lihaoyi commented Apr 10, 2025 •
edited
Loading

Part of #4885

  • Most of mill.runner.api is now in mill.api.internal
  • mill.api is now a zero-dependency module, apart from scala-library and sbt-test-interface
  • Classes that cannot fit within mill.api's zero-dependency requirement have been moved to mill.define
  • mill.api.Ctx and mill.define.Ctx have been renamed to mill.define.TaskCtx and mill.define.ModuleCtx, to avoid a conflict since neither of them can live within mill.api anymore. This should also remove a long-standing point of confusion between the two identically-named classes

Lots of stuff got moved around, but the main user-facing things like PathRef shouldn't break too many people since they're typically used from an alias e.g. mill.PathRef. The main breakage would be the renames of Ctx and Ctx, but that rename is probably necessary

@lihaoyi lihaoyi marked this pull request as ready for review April 10, 2025 10:34
@lihaoyi
Copy link
Member Author
lihaoyi commented Apr 10, 2025

The red bsp-server test passed on the run that happened on my fork (https://github.com/lihaoyi/mill-1/actions/runs/14378325520), so I'm going to assume this red a flake and go ahead and merge this

@lihaoyi lihaoyi merged commit 8ee5e9c into com-lihaoyi:main Apr 10, 2025
41 of 42 checks passed
@lefou lefou added this to the 0.13.0 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@lihaoyi @lefou
0