8000 Add helpers to debug flaky tests, that might have fixed them by alexarchambault · Pull Request #4944 · com-lihaoyi/mill · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add helpers to debug flaky tests, that might have fixed them #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2025
Merged

Add helpers to debug flaky tests, that might have fixed them #4944

merged 7 commits into from
Apr 22, 2025

Conversation

alexarchambault
Copy link
Collaborator
@alexarchambault alexarchambault commented Apr 15, 2025 •
edited
Loading

This adds more checks in two currently flaky tests, and makes them print some details when they fail. My hope is this could help understand what's going on when they fail for no obvious reason. This also retries the failing assertions in those tests after a delay, which might fix things.

@alexarchambault alexarchambault changed the title Add helpers to debug flaky test Add helpers to debug flaky tests Apr 17, 2025
@alexarchambault alexarchambault changed the title Add helpers to debug flaky tests Add helpers to debug flaky tests, that might have fixed them Apr 18, 2025
@alexarchambault
Copy link
Collaborator Author
8000

@lihaoyi @lefou Don't know if you want to have a look. Going to merge if the CI is green else, I guess. This adds some debugging messages when those flaky tests fail, but also might fix things, thanks to the small delay before checking the assertions again.

@lihaoyi
Copy link
Member
lihaoyi commented Apr 18, 2025

go for it

@alexarchambault alexarchambault merged commit c1da417 into com-lihaoyi:main Apr 22, 2025
37 checks passed
@alexarchambault alexarchambault deleted the debug-ci-failure branch April 22, 2025 19:14
@lefou lefou added this to the 0.13.0 milestone Apr 22, 2025
@alexarchambault alexarchambault mentioned this pull request Apr 28, 2025
Merged
alexarchambault added a commit that referenced this pull request Apr 28, 2025
@alexarchambault
Try to fix transient issue on CI (#5017)
ce44e5b 
Same workaround as a test nearby (see #4944)

Comes from #4917, but shouldn't
be a problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @lihaoyi @lefou
0