Move ScalaFmt into its own classloader
#4954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Apr 18, 2025
| ) | ||
| } | ||
|
|
||
| def scalafmtClassLoader: Worker[java.net.URLClassLoader] = Task.Worker { |
There was a problem hiding this comment.
Nice trick to have the classloader in its own worker, since this avoids any explicit AutoCloesable handling. I think we should keep this private though.
There was a problem hiding this comment.
Whoops sorry I missed this, I guess we may come back to it as part of #4716 when we go around privatizing everything we can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuts
mill-assembly.jarfrom 55mb to 53mb, so ~2mb of savings, with a somewhat cleaner classpath. thescalafmt-dynamiccode will be downloaded on-demand