Fail on missing interpolatable variables #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpolating missing variable to "" is error prone, possibly dangerous and hard to debug.
Also added WORKSPACE env variable
|
I think this looks reasonable to try and enforce, but we should have some story around how to handle optional environment variables. I don't know the exact use cases that those would apply, but I imagine having something like |
|
We should use whatever is common in POSIX shells for that task. I think in |
|
Since default value support is a new feature, I think it's best to do it in a separate PR. |
|
Sounds good, feel free to merge this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolating missing variable to the empty string (
"") is error prone, possibly dangerous and hard to debug. Hence, this change makes it a hard failure when a variable is missing.