Fix selective execution when multiple changes are made to one module under --watch #5032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturaz
added a commit
to arturaz/mill
that referenced
this pull request
May 1, 2025
…tion-intermittent-failure' into fix/selective-execution-intermittent-failure
lihaoyi
pushed a commit
that referenced
this pull request
May 1, 2025
…under --watch (main branch) (#5033) Forward port to `main` of #5032 If you have two modules and run `--watch {moduleA.fooCommand,moduleB.fooCommand}`, mill will run `moduleB.fooCommand` every 2nd change to `moduleA`, even if there is no changes to `moduleB`. The problem stems from the fact that when we save the changed inputs in selective execution, we did not store the inputs from `moduleB` and when selective execution runs again (the 2nd time), it thinks that *everything* in `moduleB` changed. This fix correctly saves the state of all modules when storing the selective execution state. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have two modules and run
--watch {moduleA.fooCommand,moduleB.fooCommand}, mill will runmoduleB.fooCommandevery 2nd change tomoduleA, even if there is no changes tomoduleB.The problem stems from the fact that when we save the changed inputs in selective execution, we did not store the inputs from
moduleBand when selective execution runs again (the 2nd time), it thinks that everything inmoduleBchanged.This fix correctly saves the state of all modules when storing the selective execution state.