8000 New cut at manually stopping scalac timers by alexarchambault · Pull Request #5186 · com-lihaoyi/mill · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New cut at manually stopping scalac timers #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

New cut at manually stopping scalac timers #5186

wants to merge 2 commits into from

Conversation

alexarchambault
Copy link
Collaborator

This is making the leaking thread test green without needing to ignore the timer threads in it. I pushed this code at some point in #5171, but thought this could be reverted.

@alexarchambault
Copy link
Collaborator Author

Might look deeper into it later, but CI is green with these changes (that drop the Timer mentions in LeakHygieneTests) 🤔

@lihaoyi
Copy link
Member
lihaoyi commented May 26, 2025
8000

Could you explain what this PR does and why dropping the Timer is the correct thing to do?

@alexarchambault
Copy link
Collaborator Author

@lihaoyi #5171, in its last state, only finds the timer instance, and calls cancel on it (which is supposed to terminate the timer thread). The PR here keeps doing that, but also manages to find the timer thread itself, and calls interrupt on it.

@lihaoyi
Copy link
Member
lihaoyi commented May 26, 2025

got it, but in that case why are no timer threads running after running __.compile? Since we haven't cleaned and the classloader used to compile is still hanging around, shouldn't the timer thread be still running as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

35FE
2 participants
@alexarchambault @lihaoyi
0