Refactor internal BSP tasks out of JavaModuleApi
#5214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This for now only holds a single task, but the idea is to move all bsp-tasks here.
|
Feel free to delete and move things around the API; until 1.0.0 final lands, there aren't any compatibility concerns, so best to squeeze in as much cleanup as we can |
We can instantiate module in the context of the BSP server, since the BSP can only acces a limmitted module API. Effectively, we may deal with `JavaModule`s in different meta-build levels, hence the implicit BSP context modules need to life in that scope.
|
Moved various internal BSP tasks into a dedicated trait and update the PR description. |
JavaModuleApi
|
I also identified some internal tasks to support |
lefou
added a commit
to lefou/mill
that referenced
this pull request
Jun 5, 2025
This is based on com-lihaoyi#5214
lefou
added a commit
to lefou/mill
that referenced
this pull request
Jun 5, 2025
This is based on com-lihaoyi#5214
lefou
added a commit
to lefou/mill
that referenced
this pull request
Jun 5, 2025
This is based on com-lihaoyi#5214
|
@lihaoyi I'd like to merge this one. It only juggles with unreleased API and should decouple internals from the public |
|
@lefou i havent look at it but go ahead if CI and manual testing passes |
lefou
added a commit
to lefou/mill
that referenced
this pull request
Jun 5, 2025
lefou
added a commit
that referenced
this pull request
Jun 12, 2025
Also factored new `GenIdeaInternalApi` module and moved some tasks around. This uses the same technique of an implicitly attached sub-module to avoid adding private and likely changing internals to public stable modules. this follows the previous BSP refactorings (#5214, #5261). I also took the opportunity to simplify and clean the existing code. Having a module-scoped class allows us to have some logic in a much clearer way. Removed the `GenIdeaModule.intellijModulePath` in favor to the redundant `intellijModulePathJava`. This should reduce confusion about what to override. But it needs a deprecation in Mill 0.12 which I'll add in a separate PR (#5290). Pull request: #5289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a dedicated
traitto hold internal BSP tasks. This is, to free the binary compatibly Module API from these likely changing tasks.Also refined the package layout in
mill.api.internaland introduced sub-packagesbspandidea.