Update SCL communication import method to allow the import of the att… #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliouDIAITE
reviewed
Apr 13, 2022
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/SclServiceTest.java
Outdated
Show resolved
Hide resolved
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/SclServiceTest.java
Show resolved
Hide resolved
…ributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
8b014b6 to
3977815
Compare
…plete-subnetwork-import
AliouDIAITE
previously approved these changes
Apr 19, 2022
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
…ributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
…rk-import' of https://github.com/com-pas/compas-sct into 76-rsr-bug-correction-for-issue-the-incomplete-subnetwork-import
Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
samirromdhani
approved these changes
Apr 22, 2022
AliouDIAITE
pushed a commit
that referenced
this pull request
Apr 28, 2022
#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
AliouDIAITE
pushed a commit
that referenced
this pull request
Jun 3, 2022
#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: SaintierFr 99645240+SaintierFr@users.noreply.github.com
AliouDIAITE
pushed a commit
that referenced
this pull request
Jun 3, 2022
#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
SaintierFr
added a commit
to SaintierFr/compas-sct
that referenced
this pull request
Jun 20, 2022
com-pas#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com>
SaintierFr
added a commit
to SaintierFr/compas-sct
that referenced
this pull request
Jun 20, 2022
com-pas#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
SaintierFr
added a commit
that referenced
this pull request
Jun 20, 2022
#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com>
SaintierFr
added a commit
that referenced
this pull request
Jun 22, 2022
* [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP refactoring and test needed Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP add files and tests, refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : moving code to subnetwork and refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete not yet used code Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : refactoring after remarks for pull request Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete commented code and update pom.xml Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Added CII Best Practices Badge + removed unused LFX Security Tool badge Signed-off-by: Flurb <private@tjalma.com> * [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102) [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#70] : all updatable DA should be returned Signed-off-by: massifben <105049157+massifben@users.noreply.github.com> Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com> Co-authored-by: Flurb <private@tjalma.com> Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
AliouDIAITE
added a commit
that referenced
this pull request
Aug 17, 2022
* Added Github Action for release compas-sct (#53) * Added releasing action & changed copyright to RTE FRANCE Added releasing action & changed copyright to RTE FRANCE Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> * Updated automate projects action Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> * Release 0.0.4 (#103) * [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP refactoring and test needed Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP add files and tests, refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : moving code to subnetwork and refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete not yet used code Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : refactoring after remarks for pull request Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete commented code and update pom.xml Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Added CII Best Practices Badge + removed unused LFX Security Tool badge Signed-off-by: Flurb <private@tjalma.com> * [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102) [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#70] : all updatable DA should be returned Signed-off-by: massifben <105049157+massifben@users.noreply.github.com> Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com> Co-authored-by: Flurb <private@tjalma.com> Co-authored-by: massifben <105049157+massifben@users.noreply.github.com> Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> Co-authored-by: Samir Romdhani <76203423+samirromdhani@users.noreply.github.com> Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com> Co-authored-by: Flurb <private@tjalma.com> Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
samirromdhani
pushed a commit
that referenced
this pull request
Sep 12, 2022
* [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Update SCL communication import method to allow the import of the att… (#91) * Update SCL communication import method to allow the import of the attributes Address et PhysConn if present. Signed-off-by: SAINTIER FRANCOIS <francois.saintier@rte-france.com> Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65] : correcting history for automation service Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#65 ==> 95] : correcting history for automation service: add test Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP refactoring and test needed Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP add files and tests, refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : moving code to subnetwork and refactoring Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete not yet used code Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : WIP to be refactored Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : refactoring after remarks for pull request Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#66] : delete commented code and update pom.xml Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * Added CII Best Practices Badge + removed unused LFX Security Tool badge Signed-off-by: Flurb <private@tjalma.com> * [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD (#102) [#88] : add private COMPAS_SCL_FILE_TYPE in created SCD Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com> * [#70] : all updatable DA should be returned Signed-off-by: massifben <105049157+massifben@users.noreply.github.com> Co-authored-by: SaintierFr <99645240+SaintierFr@users.noreply.github.com> Co-authored-by: Flurb <private@tjalma.com> Co-authored-by: massifben <105049157+massifben@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ributes Address et PhysConn if present.
Signed-off-by: SAINTIER FRANCOIS francois.saintier@rte-france.com