Skip to content
Navigation Menu
Open
Remove React #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to close #42 (Replace React with something simple). I have migrated the stack to just use Typescript, HTML and CSS. NO FRAMEWORKS.
Basic setup
Fastboot functionality is refactored into a class that extends
EventTarget.EventTargetbasically allows you to attach event listeners. Here is an example:Almost all of the UI is now part of
index.htmland those parts of frontend that have some kind of interactivity (ex: progress indicator, device connection status, buttons, etc) are insrc/main.tsfile. Here is an example of how progress indicator is handled:This setup should simplify the stack and hopefully is exactly what @adeebshihadeh was expecting.
Pending steps
I still have to migrate a couple of tests to this new setup. However, the project runs locally. I will need help from someone who owns an actual device to try and flash the device just to make sure everything is working fine.
@adeebshihadeh let me know if anything else is required to Lock the bounty. Thanks! Was fun working on this :)