E857 Remove sending of close event on minicart by gciotola · Pull Request #42 · commercelayer/mfe-cart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove sending of close event on minicart #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023

Conversation

gciotola
Copy link
Contributor
@gciotola gciotola commented May 17, 2023

This reverts changes applied from #40 since we decided it is not necessary to keep this logic inside the cart application.

@gciotola gciotola requested a review from malessani May 17, 2023 11:13
@gciotola gciotola added the bug Something isn't working label May 17, 2023
@gciotola gciotola marked this pull request as ready for review May 17, 2023 11:15
Copy link
Contributor
@malessani malessani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gciotola gciotola merged commit 77f4c0b into master May 17, 2023
@gciotola gciotola deleted the fix/remove-minicart-logic branch May 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0