8000 Update PaymentMethod component to conditionally hide non-stripe payment sources by gciotola · Pull Request #94 · commercelayer/mfe-cart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update PaymentMethod component to conditionally hide non-stripe payment sources #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Update PaymentMethod component to conditionally hide non-stripe payment sources #94

merged 1 commit into from
Mar 3, 2025

Conversation

gciotola
Copy link
Contributor

What I did

This pull request includes changes to the ButtonCheckout component in the packages/cart/src/components/Cart/Totals/ButtonCheckout.tsx file. The most important changes focus on improving the display logic for payment methods.

Changes to ButtonCheckout component:

  • Added a hide function to the PaymentMethod component to filter and only show Stripe payment methods.

Code cleanup:

  • Removed an unnecessary blank line in the import statements.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@gciotola gciotola self-assigned this Feb 27, 2025
@gciotola gciotola added the bug Something isn't working label Feb 27, 2025
@gciotola gciotola merged commit e5a1e70 into master Mar 3, 2025
2 checks passed
@gciotola gciotola deleted the express-payments branch March 3, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malessani malessani malessani approved these changes

@acasazza acasazza Awaiting requested review from acasazza

Assignees

@gciotola gciotola

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gciotola @malessani
0