add Dutch (nl) locale to mfe-cart #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @quanticdreams7 thanks for your PR. This has been just released. |
|
Hi @gciotola. No problem, thank you for reviewing. I did the same for MFE-My-Account, see commercelayer/mfe-my-account#160. Could you review that PR as well? Thanks |
|
Hey @quanticdreams7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Add Dutch translation in packages/cart/src/assets/locales/nl/common.json
Updated i18n config in packages/cart/src/components/i18n/index.ts
Updated pareLanguageCode in packages/cart/src/components/i18n/parseLanguageCode.ts to include nl lang
Updated react-i18next.d.ts to include nl in AllowedLocaleKeys
Updated CartPage.ts in packages/cart/specs/fixtures/CartPage.ts for Dutch lang testing
How to test
set lang to 'nl'
Checklist