Incorrect closing sourcepos column for code blocks #141

oampo · 2018-05-29T14:30:49Z

The sourcepos attribute for code blocks reports the column number for the line before the end of the block.

Here's a quick test case:

const commonmark = require('commonmark');
const parser = new commonmark.Parser();

// Annotated with line numbers
// 1 ```
// 2 hello world
// 3 ```
const md = '```\nhello world\n```';

const node = parser.parse(md);

const walker = node.walker();

while ((event = walker.next())) {
    const {node} = event;
    if (node.type === 'code_block') {
        console.log(node.sourcepos);
    }
}

I'd expect to see [[1, 1], [3, 3]] - the backticks start at L1C1 and end at L3C3. Instead, I see [[1, 1], [3, 11]], where the closing column number (11) is the length of the hello world line before the closing backticks.

The text was updated successfully, but these errors were encountered:

SonyaOrlova · 2019-09-24T17:02:50Z

i have the same problem with comments (html_block)
example:

# Example
<!-- this is a comment -->

for the comment i expect to see the following sourcepos [2, 1] [2, 26], but i get [2, 1] [2, 9]

adding this.lastLineLength = ln.length; before this.finalize here

commonmark.js/lib/blocks.js

Line 772 in ffc5d87

this.finalize(container, this.lineNumber);

solves the problem

and one more interesting thing: if i add several spaces before comment, like this:

# Example
    <!-- this is a comment -->

i get code_block type instead of html_block, and correct sourcepos

jgm · 2020-01-09T16:39:38Z

Thanks for reporting!

Improves on earlier fix to #141, which only worked for code blocks flush with the left margin.

Closes commonmark/commonmark.js#141. commonmark/commonmark.js@1f5a827 Author: John MacFarlane <jgm@berkeley.edu> Date: Thu Jan 9 08:38:20 2020 -0800

jgm closed this as completed in 1f5a827 Jan 9, 2020

jgm added a commit that referenced this issue Jan 9, 2020

Fix end source position for nested or indented fenrced code blocks.

8072c6b

Improves on earlier fix to #141, which only worked for code blocks flush with the left margin.

taku0 added a commit to taku0/cmark-el that referenced this issue Jan 11, 2020

Fix end source position for fenced code and raw HTML.

ba8ead6

Closes commonmark/commonmark.js#141. commonmark/commonmark.js@1f5a827 Author: John MacFarlane <jgm@berkeley.edu> Date: Thu Jan 9 08:38:20 2020 -0800

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorrect closing sourcepos column for code blocks #141

Incorrect closing sourcepos column for code blocks #141

Incorrect closing sourcepos column for code blocks #141

Incorrect closing sourcepos column for code blocks #141

Comments