ENH: Set a continuous CTF for the ctkVTKScalarsToColorsView as an edi… #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table function or as a read only one
lassoan
approved these changes
May 16, 2022
There was a problem hiding this comment.
Thank you, it looks good to me.
It could be better to show the points just not make them interactive, and it would be nicer to allow changing editable state anytime (not just when setting the function to the plots). But your implementation follows current patterns used in this file, so it is acceptable - the design can be improved in the future.
I tried to modify the widget and the view by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
None yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…table function or as a read only one
This is a part of the first bug fix in the Slicer color legend issue.