comanche2008 · pull · Jun 5, 2025 · Jun 5, 2025 · Jun 5, 2025 · Jun 5, 2025
diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml
@@ -0,0 +1,91 @@
+name: Pylint Code Quality Check
+
+on:
+  # 允许手动触发
+  workflow_dispatch:
+
+jobs:
+  pylint:
+    runs-on: ubuntu-latest
+    name: Pylint Code Quality Check
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.12'
+        cache: 'pip'
+
+    - name: Cache pip dependencies
+      uses: actions/cache@v4
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt', '**/requirements.in') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+
+    - name: Install dependencies
+      run: |
+        python -m pip install --upgrade pip setuptools wheel
+        pip install pylint
+        # 安装项目依赖
+        if [ -f requirements.txt ]; then
+          echo "📦 安装 requirements.txt 中的依赖..."
+          pip install -r requirements.txt
+        elif [ -f requirements.in ]; then
+          echo "📦 安装 requirements.in 中的依赖..."
+          pip install -r requirements.in
+        else
+          echo "⚠️ 未找到依赖文件，仅安装 pylint"
+        fi
+
+    - name: Verify pylint config
+      run: |
+        # 检查项目中的pylint配置文件是否存在
+        if [ -f .pylintrc ]; then
+          echo "✅ 找到项目配置文件: .pylintrc"
+          echo "配置文件内容预览:"
+          head -10 .pylintrc
+        else
+          echo "❌ 未找到 .pylintrc 配置文件"
+          exit 1
+        fi
+    - name: Run pylint
+      run: |
+        # 运行pylint，检查主要的Python文件
+        echo "🚀 运行 Pylint 错误检查..."
+
+        # 检查主要目录 - 只关注错误，如果有错误则退出
+        echo "📂 检查 app/ 目录..."
+        pylint app/ --output-format=colorized --reports=yes --score=yes
+
+        # 检查根目录的Python文件
+        echo "📂 检查根目录 Python 文件..."
+        for file in $(find . -name "*.py" -not -path "./.*" -not -path "./.venv/*" -not -path "./build/*" -not -path "./dist/*" -not -path "./tests/*" -not -path "./docs/*" -not -path "./__pycache__/*" -maxdepth 1); do
+          echo "检查文件: $file"
+          pylint "$file" --output-format=colorized || exit 1
+        done
+
+        # 生成详细报告
+        echo "📊 生成 Pylint 详细报告..."
+        pylint app/ --output-format=json > pylint-report.json || true
+
+        # 显示评分（仅供参考）
+        echo "📈 Pylint 评分（仅供参考）:"
+        pylint app/ --score=yes --reports=no | tail -2 || true
+
+    - name: Upload pylint report
+      uses: actions/upload-artifact@v4
+      if: always()
+      with:
+        name: pylint-report
+        path: pylint-report.json
+
+    - name: Summary
+      run: |
+        echo "🎉 Pylint 检查完成！"
+        echo "✅ 没有发现语法错误或严重问题"
+        echo "📊 详细报告已保存为构建工件" 
diff --git a/.gitignore b/.gitignore
@@ -23,4 +23,8 @@ config/cache/
 *.pyc
 *.log
 .vscode
-venv
+venv
+
+# Pylint
+pylint-report.json
+.pylint.d/
diff --git a/.pylintrc b/.pylintrc
@@ -0,0 +1,83 @@
+[MASTER]
+# 指定Python路径
+init-hook='import sys; sys.path.append(".")'
+
+# 忽略的文件和目录
+ignore=.git,__pycache__,.venv,build,dist,tests,docs
+
+# 并行作业数量
+jobs=0
+
+[MESSAGES CONTROL]
+# 只关注错误级别的问题，禁用警告、约定和重构建议
+# E = Error (错误) - 会导致构建失败
+# W = Warning (警告) - 仅显示，不会失败
+# R = Refactor (重构建议) - 仅显示，不会失败  
+# C = Convention (约定) - 仅显示，不会失败
+# I = Information (信息) - 仅显示，不会失败
+
+# 禁用大部分警告、约定和重构建议，只保留错误和重要警告
+disable=all
+enable=error,
+       syntax-error,
+       undefined-variable,
+       used-before-assignment,
+       unreachable,
+       return-outside-function,
+       yield-outside-function,
+       continue-in-finally,
+       nonlocal-without-binding,
+       undefined-loop-variable,
+       redefined-builtin,
+       not-callable,
+       assignment-from-no-return,
+       no-value-for-parameter,
+       too-many-function-args,
+       unexpected-keyword-arg,
+       redundant-keyword-arg,
+       import-error,
+       relative-beyond-top-level
+
+[REPORTS]
+# 设置报告格式
+output-format=colorized
+reports=yes
+score=yes
+
+[FORMAT]
+# 最大行长度
+max-line-length=120
+# 缩进大小
+indent-string='    '
+
+[DESIGN]
+# 最大参数数量
+max-args=10
+# 最大本地变量数量
+max-locals=20
+# 最大分支数量
+max-branches=15
+# 最大语句数量
+max-statements=50
+# 最大父类数量
+max-parents=7
+# 最大属性数量
+max-attributes=10
+# 最小公共方法数量
+min-public-methods=1
+# 最大公共方法数量
+max-public-methods=25
+
+[SIMILARITIES]
+# 最小相似行数
+min-similarity-lines=6
+# 忽略注释
+ignore-comments=yes
+# 忽略文档字符串
+ignore-docstrings=yes
+# 忽略导入
+ignore-imports=yes
+
+[TYPECHECK]
+# 生成缺失成员提示的类列表
+generated-members=requests.packages.urllib3 
diff --git a/app/actions/send_message.py b/app/actions/send_message.py
@@ -4,7 +4,7 @@
 
 from app.actions import BaseAction, ActionChain
 from app.schemas import ActionParams, ActionContext, Notification
-from core.config import settings
+from app.core.config import settings
 
 
 class SendMessageParams(ActionParams):

diff --git a/app/api/endpoints/discover.py b/app/api/endpoints/discover.py
@@ -7,9 +7,9 @@
 from app.core.security import verify_token
 from app.schemas import DiscoverSourceEventData
 from app.schemas.types import ChainEventType, MediaType
-from chain.bangumi import BangumiChain
-from chain.douban import DoubanChain
-from chain.tmdb import TmdbChain
+from app.chain.bangumi import BangumiChain
+from app.chain.douban import DoubanChain
+from app.chain.tmdb import TmdbChain
 
 router = APIRouter()
 

diff --git a/app/api/endpoints/system.py b/app/api/endpoints/system.py
@@ -301,6 +301,8 @@ def set_setting(key: str, value: Union[list, dict, bool, int, str] = None,
                 value=value,
                 change_type="update"
             ))
+        elif success is None:
+            success = True
         return schemas.Response(success=success, message=message)
     elif key in {item.value for item in SystemConfigKey}:
         if isinstance(value, list):

diff --git a/app/core/cache.py b/app/core/cache.py
@@ -196,7 +196,7 @@ def get(self, key: str, region: Optional[str] = DEFAULT_CACHE_REGION) -> Any:
             return None
         return region_cache.get(key)
 
-    def delete(self, key: str, region: Optional[str] = DEFAULT_CACHE_REGION) -> None:
+    def delete(self, key: str, region: Optional[str] = DEFAULT_CACHE_REGION):
         """
         删除缓存
 
@@ -205,7 +205,7 @@ def delete(self, key: str, region: Optional[str] = DEFAULT_CACHE_REGION) -> None
         """
         region_cache = self.__get_region_cache(region)
         if region_cache is None:
-            return None
+            return
         with lock:
             del region_cache[key]
 

diff --git a/app/core/meta/releasegroup.py b/app/core/meta/releasegroup.py
@@ -81,7 +81,6 @@ class ReleaseGroupsMatcher(metaclass=Singleton):
     }
 
     def __init__(self):
-        self.systemconfig = SystemConfigOper()
         release_groups = []
         for site_groups in self.RELEASE_GROUPS.values():
             for release_group in site_groups:
@@ -98,7 +97,7 @@ def match(self, title: str = None, groups: str = None):
             return ""
         if not groups:
             # 自定义组
-            custom_release_groups = self.systemconfig.get(SystemConfigKey.CustomReleaseGroups)
+            custom_release_groups = SystemConfigOper().get(SystemConfigKey.CustomReleaseGroups)
             if isinstance(custom_release_groups, list):
                 custom_release_groups = list(filter(None, custom_release_groups))
             if custom_release_groups:

diff --git a/app/core/metainfo.py b/app/core/metainfo.py
@@ -197,67 +197,3 @@ def find_metainfo(title: str) -> Tuple[str, dict]:
     elif metainfo.get('begin_episode') and not metainfo.get('end_episode'):
         metainfo['total_episode'] = 1
     return title, metainfo
-
-
-def test_find_metainfo():
-    """
-    测试find_metainfo函数的各种ID识别格式
-    """
-    test_cases = [
-        # 测试 [tmdbid=xxxx] 格式
-        ("The Vampire Diaries (2009) [tmdbid=18165]", "18165"),
-        # 测试 [tmdbid-xxxx] 格式
-        ("Inception (2010) [tmdbid-27205]", "27205"),
-        # 测试 [tmdb=xxxx] 格式
-        ("Breaking Bad (2008) [tmdb=1396]", "1396"),
-        # 测试 [tmdb-xxxx] 格式
-        ("Interstellar (2014) [tmdb-157336]", "157336"),
-        # 测试 {tmdbid=xxxx} 格式
-        ("Stranger Things (2016) {tmdbid=66732}", "66732"),
-        # 测试 {tmdbid-xxxx} 格式
-        ("The Matrix (1999) {tmdbid-603}", "603"),
-        # 测试 {tmdb=xxxx} 格式
-        ("Game of Thrones (2011) {tmdb=1399}", "1399"),
-        # 测试 {tmdb-xxxx} 格式
-        ("Avatar (2009) {tmdb-19995}", "19995"),
-    ]
-
-    for title, expected_tmdbid in test_cases:
-        cleaned_title, metainfo = find_metainfo(title)
-        found_tmdbid = metainfo.get('tmdbid')
-
-        print(f"原标题: {title}")
-        print(f"清理后标题: {cleaned_title}")
-        print(f"期望的tmdbid: {expected_tmdbid}")
-        print(f"识别的tmdbid: {found_tmdbid}")
-        print(f"结果: {'通过' if found_tmdbid == expected_tmdbid else '失败'}")
-        print("-" * 50)
-
-
-def test_meta_info_path():
-    """
-    测试MetaInfoPath函数
-    """
-    # 测试文件路径
-    path_tests = [
-        # 文件名中包含tmdbid
-        Path("/movies/The Vampire Diaries (2009) [tmdbid=18165]/The.Vampire.Diaries.S01E01.1080p.mkv"),
-        # 目录名中包含tmdbid
-        Path("/movies/Inception (2010) [tmdbid-27205]/Inception.2010.1080p.mkv"),
-        # 父目录名中包含tmdbid
-        Path("/movies/Breaking Bad (2008) [tmdb=1396]/Season 1/Breaking.Bad.S01E01.1080p.mkv"),
-        # 祖父目录名中包含tmdbid
-        Path("/tv/Game of Thrones (2011) {tmdb=1399}/Season 1/Game.of.Thrones.S01E01.1080p.mkv"),
-    ]
-
-    for path in path_tests:
-        meta = MetaInfoPath(path)
-        print(f"测试路径: {path}")
-        print(f"识别结果: tmdbid={meta.tmdbid}")
-        print("-" * 50)
-
-
-if __name__ == "__main__":
-    # 运行测试函数
-    # test_find_metainfo()
-    test_meta_info_path()