チャンネルに入るエンドポイントを実装 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements an endpoint for joining a channel by enabling users to be added to channels. Key changes include:
- A new usecase method (AddUserToChannel) and corresponding handler (HandleAddUserToChannel) to support adding users to a channel.
- Updates to API specifications with the removal of the old openapi.yml and introduction of a new api/openapi.yaml.
- Addition of new tests and minor logging improvements in persistence.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openapi.yml | Removed old API spec definitions |
| api/usecase/channel.go | Added AddUserToChannel usecase method |
| api/interface/handler/channel.go | Added HandleAddUserToChannel endpoint handler and updated URI parameter binding |
| api/test/channel_test.go | Added tests for channel user addition endpoint |
| api/openapi.yaml | Added new API spec file with updated version and endpoints |
| api/infrastructure/persistence/user_channels.go | Improved logging and adjusted record lookup for user-channel relationships |
| api/infrastructure/persistence/channel.go | Modified query construction for GetByID |
| api/cmd/app/app.go | Updated routing to include the new channel users endpoint |
| Makefile | Added test command |
Comments suppressed due to low confidence (1)
api/usecase/channel.go:70
- [nitpick] The field name 'userChannelsRespository' appears to be misspelled; consider renaming it to 'userChannelsRepository' for clarity and consistency.
userChannel, err := cu.userChannelsRespository.Insert(userID, id)
| result := ccp.db.Where("user_id = ? AND channel_id = ?", userID, channelID).First(&userChannels) | ||
| if err := result.Error; err != nil { | ||
| if errors.Is(err, gorm.ErrRecordNotFound) { | ||
| slog.Info(fmt.Sprintf("a relation between user %s and channe %s is not found.", userID, channelID)) |
There was a problem hiding this comment.
There is a typo in the log message: 'channe' should be corrected to 'channel'.
Suggested change
| slog.Info(fmt.Sprintf("a relation between user %s and channe %s is not found.", userID, channelID)) | |
| slog.Info(fmt.Sprintf("a relation between user %s and channel %s is not found.", userID, channelID)) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8