8000 [NA] add new models to playground for open router by Nimrod007 · Pull Request #2404 · comet-ml/opik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[NA] add new models to playground for open router #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

Nimrod007
Copy link
Collaborator
@Nimrod007 Nimrod007 commented Jun 5, 2025

Details

Added 2 new models to open router list

Issues

Resolves #

Testing

ran FE and BE locally and tested models in playground
in addition tested models in online eval flow.

Documentation

@Nimrod007 Nimrod007 requested a review from a team as a code owner June 5, 2025 18:12
@Nimrod007 Nimrod007 requested a review from Copilot June 5, 2025 18:13
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new online model variants to the open router list.

  • Added OPENAI_GPT_4_ONLINE and OPENAI_GPT_4O_ONLINE enums to both the frontend and backend.
  • Updated the provider models hook to include the new online variants.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
apps/opik-frontend/src/types/providers.ts Added two new enum values for online models.
apps/opik-frontend/src/hooks/useLLMProviderModelsData.ts Updated provider models mapping with new online model entries.
apps/opik-backend/src/main/java/com/comet/opik/infrastructure/llm/openrouter/OpenRouterModelName.java Added two new enum entries representing the online models.

Copy link
Collaborator
@aadereiko aadereiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! please check that "openai/gpt-4o:online" works with online evaluation before merging :)

Copy link
Contributor
github-actions bot commented Jun 5, 2025

Backend Tests Results

  168 files    168 suites   15m 26s ⏱️
3 720 tests 3 717 ✅ 3 💤 0 ❌
3 715 runs  3 712 ✅ 3 💤 0 ❌

Results for commit 277aaa6.

@Nimrod007 Nimrod007 merged commit 96980d0 into main Jun 5, 2025
13 of 24 checks passed
@Nimrod007 Nimrod007 deleted the nimrod/new-model branch June 5, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0