[OPIK-1799] [FE] Add support for filtering by config (metadata) to experiments #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to filter experiments by arbitrary metadata fields (“configuration”) alongside dataset filters, replacing the old one-off dataset filter button with a generic FiltersButton and wiring filters through data hooks and pages.
- Introduce
FilterRowConfigand make columns “disposable” so they can only be used once per filter. - Update
useExperimentsList/useGroupedExperimentsListto acceptfiltersand send them to the API. - Replace old
ExperimentsFiltersButtonwith a configurableFiltersButton, new helper components (DatasetSelectBox,ExperimentsPathsAutocomplete), and page wiring for Experiments, ExperimentsTab, and OptimizationsPage.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/opik-frontend/src/types/shared.ts | Added COLUMN_DATASET_ID and a disposable flag on ColumnData. |
| apps/opik-frontend/src/types/filters.ts | Defined FilterRowConfig and updated imports. |
| apps/opik-frontend/src/api/datasets/useExperimentsList.ts | Accept and process filters in experiment list API calls. |
| apps/opik-frontend/src/hooks/useGroupedExperimentsList.ts | Propagate filters into grouped experiments hook. |
| apps/opik-frontend/src/components/shared/FiltersButton/* | Generic filter UI (FiltersButton, FilterRow, ColumnSelector, StringRow, DictionaryRow). |
| apps/opik-frontend/src/components/pages-shared/experiments/* | New ExperimentsPathsAutocomplete, DatasetSelectBox components. |
| apps/opik-frontend/src/components/pages/PromptPage/ExperimentsTab/ExperimentsTab.tsx | Replace old filter UI with new FiltersButton and metadata column. |
| apps/opik-frontend/src/components/pages/OptimizationsPage/OptimizationsPage.tsx | Wire filters into optimizations list. |
| apps/opik-frontend/src/components/pages/ExperimentsPage/ExperimentsPage.tsx | Wire filters into main experiments page. |
Comments suppressed due to low confidence (3)
apps/opik-frontend/src/components/pages-shared/experiments/ExperimentsPathsAutocomplete/ExperimentsPathsAutocomplete.tsx:1
- [nitpick] This new
ExperimentsPathsAutocompletecomponent does not have accompanying unit or integration tests. Consider adding tests to cover its path extraction and filtering logic.
import React, { useMemo } from "react";
apps/opik-frontend/src/components/pages/OptimizationsPage/OptimizationsPage.tsx:160
- You're using
JsonParamhere but it hasn't been imported. Addimport { JsonParam } from 'use-query-params'(or your project’s equivalent) so this compiles.
const [filters = [], setFilters] = useQueryParam("filters", JsonParam, {
apps/opik-frontend/src/components/pages/ExperimentsPage/ExperimentsPage.tsx:213
- You're using
JsonParamhere but it hasn't been imported. Addimport { JsonParam } from 'use-query-params'(or your project’s equivalent) so this compiles.
const [filters = [], setFilters] = useQueryParam("filters", JsonParam, {
8000
apps/opik-frontend/src/components/pages/PromptPage/ExperimentsTab/ExperimentsTab.tsx
Show resolved
Hide resolved
aadereiko
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation