8000 Code metrics Internet access via config by Nimrod007 · Pull Request #2521 · comet-ml/opik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Code metrics Internet access via config #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

Code metrics Internet access via config #2521

merged 3 commits into from
Jun 19, 2025

Conversation

Nimrod007
Copy link
Collaborator

Details

This will allow to run code metrics via docker executor with internet.

new config added PYTHON_CODE_EXECUTOR_ALLOW_NETWORK
system behavior has not changed and it false be default.

Issues

Resolves #

Testing

tested with docker compose with following setup

        PYTHON_CODE_EXECUTOR_IMAGE_TAG: "1.7.35"
        PYTHON_CODE_EXECUTOR_STRATEGY: "docker"
        PYTHON_CODE_EXECUTOR_PARALLEL_NUM: 10
        PYTHON_CODE_EXECUTOR_EXEC_TIMEOUT_IN_SECS: 5
        PYTHON_CODE_EXECUTOR_ALLOW_NETWORK: "true"

and with false

created a code metric with outgoing call. validated it fails and passed according to the config.

Documentation

@Nimrod007 Nimrod007 requested review from a team as code owners June 19, 2025 16:54
Nimrod007
Nimrod007 commented Jun 19, 2025
View reviewed changes
@Nimrod007 Nimrod007 requested a review from andrescrz June 19, 2025 16:55
@github-actions GitHub Actions
Copy link
Contributor

Python Backend Tests Results

37 tests   35 ✅  2m 29s ⏱️
 1 suites   2 💤
 1 files     0 ❌

Results for commit aaea404.

@Nimrod007 Nimrod007 merged commit 604d1cf into main Jun 19, 2025
8 checks passed
@Nimrod007 Nimrod007 deleted the nimrod/codeEvalWithNetwork branch June 19, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagohora thiagohora thiagohora approved these changes

@andrescrz andrescrz Awaiting requested review from andrescrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nimrod007 @thiagohora @CometActions
0