8000 NO-JIRA: Exclude TypeScript Fern classes from typecheck by andrescrz · Pull Request #2561 · comet-ml/opik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NO-JIRA: Exclude TypeScript Fern classes from typecheck #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

NO-JIRA: Exclude TypeScript Fern classes from typecheck #2561

merged 2 commits into from
Jun 24, 2025

Conversation

andrescrz
Copy link
Collaborator
@andrescrz andrescrz commented Jun 24, 2025 •
edited
Loading

Details

Fern auto-generated code from the Open API spec for the TypeScript SDK is found under sdks/typescript/src/opik/rest_api. Excluded from typecheck.

Issues

N/A

Testing

Documentation

N/A

@andrescrz andrescrz marked this pull request as ready for review June 24, 2025 08:31
@andrescrz andrescrz requested review from a team as code owners June 24, 2025 08:31
aadereiko
aadereiko requested changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@aadereiko aadereiko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend putting into another place as the number of ignored folders might grow over time. Moreover, we already have it for ./node_modules.

You can add it here:
opik/sdks/typescript/tsconfig.json

  "exclude": [
    "node_modules"
  ]

@andrescrz
Copy link
Collaborator Author
andrescrz commented Jun 24, 2025 •
edited
Loading

I would recommend putting into another place as the number of ignored folders might grow over time. Moreover, we already have it for ./node_modules.

You can add it here: opik/apps/opik-frontend/tsconfig.json

  "exclude": [
    "node_modules"
  ]

Makes sense. Done in the 2nd revision. @aadereiko please review again. Just keep in mind that I added it to the SDK folder, instead the FE.

@andrescrz andrescrz merged commit 86f9251 into main Jun 24, 2025
8 checks passed
@andrescrz andrescrz deleted the andrescrz/NO-JIRA-excluded-fern-classes-typescript-typecheck branch June 24, 2025 08:42
andrescrz added a commit that referenced this pull request Jun 24, 2025
@andrescrz
Revert "NO-JIRA: Exclude TypeScript Fern classes from typecheck (#2561)"
2c0cd6c 
This reverts commit 86f9251.
@andrescrz andrescrz mentioned this pull request Jun 24, 2025
Merged
@andrescrz andrescrz self-assigned this Jun 24, 2025
@andrescrz andrescrz added Bug Something isn't working javascript Pull requests that update Javascript code Typescript SDK labels Jun 24, 2025
aadereiko pushed a commit that referenced this pull request Jun 24, 2025
@andrescrz
Revert "NO-JIRA: Exclude TypeScript Fern classes from typecheck (#2561)…
50ea01b 
…" (#2563)

This reverts commit 86f9251.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadereiko aadereiko aadereiko approved these changes

Assignees

@andrescrz andrescrz

Labels
Bug Something isn't working javascript Pull requests that update Javascript code Typescript SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrescrz @aadereiko
0