8000 mempool/lanes: Allow lanes to have the same priority · Issue #4014 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mempool/lanes: Allow lanes to have the same priority #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2803
hvanz opened this issue Sep 6, 2024 · 1 comment · Fixed by #4092
Closed
Tracked by #2803

mempool/lanes: Allow lanes to have the same priority #4014

hvanz opened this issue Sep 6, 2024 · 1 comment · Fixed by #4092
Assignees
@jmalicevic
Labels
mempool
Milestone
2024-Q3

Comments

@hvanz
Copy link
Member
hvanz commented Sep 6, 2024 •
edited
Loading

Currently a lane is identified by its priority, so different lanes cannot have the same priority. This limitation was only made to simplify the prototype.
@hvanz hvanz added the mempool label Sep 6, 2024
@hvanz hvanz added this to CometBFT Sep 6, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Sep 6, 2024
@jmalicevic jmalicevic self-assigned this Sep 11, 2024
@jmalicevic jmalicevic moved this from Todo to In Progress in CometBFT Sep 11, 2024
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 11, 2024
@hvanz hvanz mentioned this issue Sep 12, 2024
Closed
42 tasks
@jmalicevic jmalicevic mentioned this issue Sep 13, 2024
Merged
3 tasks
@hvanz hvanz linked a pull request Sep 16, 2024 that will close this issue
feat(mempool/lanes): Allow lanes with equal priorities #4092
Merged
3 tasks
jmalicevic added a commit that referenced this issue Sep 20, 2024
@jmalicevic @hvanz
feat(mempool/lanes): Allow lanes with equal priorities (#4092)
8e875cb 
Closes #4014 .

The PR changes the proto files in `InfoResponse` to return a map of
`LaneID(string) : LanePrio(uint32)` instead of an array of priorities
and the default lane is identified by its ID (a string).

CheckTx returns a `LaneID` (a string).

Before marking it ready for review, we need to make sure that the corner
case of default lane and priorities are properly addressed now with
these changes.

---

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
Co-authored-by: hvanz <hernan.vanzetto@gmail.com>
@jmalicevic
Copy link
Contributor

Closed by #4079

@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

Successfully merging a pull request may close this issue.

feat(mempool/lanes): Allow lanes with equal priorities cometbft/cometbft
2 participants
@jmalicevic @hvanz
0