8000 crypto/bls12381: Sign and Verify should use dstMinPk · Issue #4783 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

crypto/bls12381: Sign and Verify should use dstMinPk #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
melekes opened this issue Jan 7, 2025 · 0 comments · Fixed by #4813
Closed

crypto/bls12381: Sign and Verify should use dstMinPk #4783

melekes opened this issue Jan 7, 2025 · 0 comments · Fixed by #4813
Assignees
@melekes
Labels
bug Something isn't working crypto Cryptography-related

Comments

@melekes
Copy link
Contributor
melekes commented Jan 7, 2025

See berachain#11 (comment)

In #3860 we forgot to update the dst for signing and verifying operations. It should be dstMinPk, not dstMinSig because, currently, we're optimizing for the minimal public key.
@melekes melekes added bug Something isn't working crypto Cryptography-related needs-triage This issue/PR has not yet been triaged by the team. labels Jan 7, 2025
@melekes melekes mentioned this issue Jan 7, 2025
Merged
@sergio-mena sergio-mena removed the needs-triage This issue/PR has not yet been triaged by the team. label Jan 10, 2025
melekes added a commit that referenced this issue Jan 13, 2025
@melekes
fix(crypto/bls12381): modify Sign, Verify
b18f093 
to use `dstMinPk`

Closes #4783
@melekes melekes mentioned this issue Jan 13, 2025
Merged
@melekes melekes self-assigned this Jan 13, 2025
@melekes melekes added this to CometBFT Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jan 13, 2025
@melekes melekes moved this from Todo to Ready for Review in CometBFT Jan 13, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2025
@melekes @mergify
fix(crypto/bls12381): modify Sign, Verify (#4813)
f2d9ae0 
to use `dstMinPk`

Closes #4783

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in CometBFT Jan 23, 2025
mergify bot added a commit that referenced this issue Jan 23, 2025
@melekes @mergify
fix(crypto/bls12381): modify Sign, Verify (#4813)
2a44e0e 
to use `dstMinPk`

Closes #4783

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f2d9ae0)
@mergify mergify bot mentioned this issue Jan 23, 2025
Merged
mergify bot added a commit that referenced this issue Jan 23, 2025
@mergify @melekes
fix(crypto/bls12381): modify Sign, Verify (backport #4813) (#4871)
1fb89c8 
to use `dstMinPk`

Closes #4783<hr>This is an automatic backport of pull request #4813 done
by [Mergify](https://mergify.com).

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
bug Something isn't working crypto Cryptography-related
Projects
No open projects
CometBFT
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(crypto/bls12381): modify Sign, Verify cometbft/cometbft
2 participants
@melekes @sergio-mena
0