10000 Upgrade to Go 1.19 · Issue #174 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to Go 1.19 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thanethomson opened this issue Jan 20, 2023 · 4 comments
Closed

Upgrade to Go 1.19 #174

thanethomson opened this issue Jan 20, 2023 · 4 comments
Labels
tools Anything relating to tooling within the repo
Milestone
2023-Q1

Comments

@thanethomson
Copy link
Contributor
thanethomson commented Jan 20, 2023 •
edited by lasarojc
Loading

Following from #173, at what point should we consider upgrading the codebase and our tooling to use Go 1.19?

And in general, what are our criteria for updating to support a new version of Go? On the Rust side of development at Informal, we always update to the latest stable version of Rust the moment it's released.

PRs addressing this
@thanethomson thanethomson added the tools Anything relating to tooling within the repo label Jan 20, 2023
@sergio-mena
Copy link
Contributor

My view is that we probably want to be aligned with the SDK when changing the (recommended) version of Go

@thanethomson
Copy link
Contributor Author

I see they use 1.18 in their v0.46 release line at present: https://github.com/cosmos/cosmos-sdk/blob/89e956c021edb1ec3e9d496b5efbcd11f3997d27/go.mod#L1

And 1.19 in their v0.47 release line: https://github.com/cosmos/cosmos-sdk/blob/504acaeab7985f7c079000b6015c08552ece9b0f/go.mod#L1

This was referenced Jan 25, 2023
Merged
Merged
@thanethomson
Copy link
Contributor Author

I'm checking whether this actually works in #206 and #208.

@andynog
Copy link
Contributor
andynog commented Feb 17, 2023 •
edited
Loading

The SDK updated to go 1.20.0 as of last week and on the README it says it requires 1.20+
cosmos/cosmos-sdk@ad847c4

@lasarojc lasarojc mentioned this issue Feb 20, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in CometBFT 2023 Feb 24, 2023
@lasarojc lasarojc mentioned this issue Feb 24, 2023
Closed
@thanethomson thanethomson added this to the 2023-Q1 milestone Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Anything relating to tooling within the repo
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q1
Development

No branches or pull requests
4 participants
@thanethomson @lasarojc @sergio-mena @andynog
0