8000 Upgrade to Go 1.19 on `v0.37.x` by thanethomson · Pull Request #208 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to Go 1.19 on v0.37.x #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 20, 2023
Merged

Upgrade to Go 1.19 on v0.37.x #208

merged 10 commits into from
Feb 20, 2023

Conversation

thanethomson
Copy link
Contributor

Partially addresses #174, and backports #206 to the v0.37.x branch.

PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@thanethomson
Upgrade to Go 1.19 on v0.37.x
c13e91c 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson changed the title Upgrade to Go 1.19 on v0.37.x Upgrade to Go 1.19 on v0.37.x Jan 25, 2023
@thanethomson thanethomson mentioned this pull request Jan 25, 2023
Closed
@github-actions
Copy link
github-actions bot commented Feb 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Feb 5, 2023
@thanethomson thanethomson added wip Work in progress and removed stale For use by stalebot labels Feb 5, 2023
@lasarojc lasarojc marked this pull request as ready for review February 20, 2023 14:28
@lasarojc lasarojc requested a review from a team as a code owner February 20, 2023 14:28
@lasarojc
Force a specific go version for vul-check. Should be reverted to not …
6ea165f 
…specifying the patch number.
@lasarojc
Use the latest patch release of 1.19
95b96e8
@lasarojc
Revert "Use the latest patch release of 1.19"
cbf88fb 
This reverts commit 95b96e8.

Revert "Force a specific go version for vul-check. Should be reverted to not specifying the patch number."

This reverts commit 6ea165f.
@sergio-mena
Copy link
Contributor

I think we should replace the occurrences in README.md and .github, shouldn't we?

% find . -type f | grep -v '\.svg$' | xargs grep -n '1\.18[^\.0-9]'
./README.md:64:| Go version  | Go 1.18 or higher |
./README.md:164:[go-badge]: https://img.shields.io/badge/go-1.18-blue.svg
./.github/workflows/e2e-manual-multiversion.yml:20:          go-version: '1.18'
./.github/workflows/e2e-nightly-34x.yml:24:          go-version: '1.18'
%

@lasarojc
Copy link
Contributor

I think we should replace the occurrences in README.md and .github, shouldn't we?

% find . -type f | grep -v '\.svg$' | xargs grep -n '1\.18[^\.0-9]'
./README.md:64:| Go version  | Go 1.18 or higher |
./README.md:164:[go-badge]: https://img.shields.io/badge/go-1.18-blue.svg
./.github/workflows/e2e-manual-multiversion.yml:20:          go-version: '1.18'
./.github/workflows/e2e-nightly-34x.yml:24:          go-version: '1.18'
%

Thanks, @sergio-mena .
Updated the README to note that 0.34 and 0.37 use different go, for now.
Also updated the e2e multi version.

@lasarojc lasarojc added automerge and removed wip Work in progress labels Feb 20, 2023
@lasarojc lasarojc merged commit e523f12 into v0.37.x Feb 20, 2023
@lasarojc lasarojc deleted the thane/v0.37.x/174-go1.19 branch February 20, 2023 22:10
@faddat faddat mentioned this pull request Jan 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees
No one assigned
Labels
automerge
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thanethomson @sergio-mena @lasarojc
A 0