8000 ADR: Due-diligence on the three items in "Alternative Approaches" section · Issue #3110 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ADR: Due-diligence on the three items in "Alternative Approaches" section #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
Tracked by #2803
sergio-mena opened this issue May 23, 2024 · 1 comment
Closed
4 tasks done
Tracked by #2803

ADR: Due-diligence on the three items in "Alternative Approaches" section #3110

sergio-mena opened this issue May 23, 2024 · 1 comment
Assignees
@sergio-mena
Labels
adr Issue relating to the implementation of a specific ADR mempool
Milestone
2024-Q3

Comments

@sergio-mena
Copy link
Contributor
sergio-mena commented May 23, 2024 •
edited
Loading

Alternative approaches to look into:

These tasks are to be time-boxed: 1-2 days each
@sergio-mena sergio-mena mentioned this issue May 23, 2024
Closed
42 tasks
@sergio-mena sergio-mena self-assigned this May 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT May 23, 2024
@sergio-mena sergio-mena moved this from Todo to In Progress in CometBFT May 23, 2024
@sergio-mena sergio-mena added this to the 2024-Q2 milestone May 23, 2024
@sergio-mena sergio-mena changed the title ADR: Due-diligence on the three items in section ADR: Due-diligence on the three items in _Alternative Approaches_ section May 23, 2024
@sergio-mena sergio-mena changed the title ADR: Due-diligence on the three items in _Alternative Approaches_ section ADR: Due-diligence on the three items in *Alternative Approaches* section May 23, 2024
@sergio-mena sergio-mena changed the title ADR: Due-diligence on the three items in *Alternative Approaches* section ADR: Due-diligence on the three items in "Alternative Approaches" section May 23, 2024
@sergio-mena sergio-mena added the adr Issue relating to the implementation of a specific ADR label May 23, 2024
@sergio-mena sergio-mena mentioned this issue May 24, 2024
Merged
2 tasks
sergio-mena added a commit that referenced this issue May 27, 2024
@sergio-mena @hvanz
docs(mempool): added network consistency properties and Priority Memp…
3343938 
…ool (#3116)

Partially addresses #3110

Added subsection "Priority mempool" in "Alternative approaces" section.

I also added extra properties in the previous section: those properties
are one of the core points in our current discussions with our users,
and I wanted to relate it to the priority mempool.

---

#### PR checklist

- ~~[ ] Tests written/updated~~
- ~~[ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
This was referenced May 28, 2024
Merged
Merged
sergio-mena added a commit that referenced this issue May 29, 2024
@sergio-mena @andynog
docs(mempool): skip's Block SDK (#3141)
cd87b61 
Partially addresses #3110

Added subsection "Priority mempool" in "Alternative approaches" section
with the description of Skip's block SDK and how it compares to the
Mempool QoS design.


---

#### PR checklist

- ~~[ ] Tests written/updated~~
- ~~[ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
@adizere adizere modified the milestones: 2024-Q2, 2024-Q3 Jul 18, 2024
@sergio-mena
Copy link
Contributor Author

@adizere still reading on ethereum preconfirmations. Will close this when I'm back from vacation. This shouldn't block any other work on Mempool QoS

@hvanz hvanz closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in CometBFT Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergio-mena sergio-mena

Labels
adr Issue relating to the implementation of a specific ADR mempool
Projects
No open projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

No branches or pull requests
3 participants
@adizere @sergio-mena @hvanz
0